Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chef generate build-cookbook removed(cherrypicked from 166) #171

Merged
merged 11 commits into from
May 4, 2021
Merged

chef generate build-cookbook removed(cherrypicked from 166) #171

merged 11 commits into from
May 4, 2021

Conversation

i5pranay93
Copy link
Contributor

@i5pranay93 i5pranay93 commented May 4, 2021 •
edited
Loading

Description

Since workflow was deprecated we no longer need build-cookbook functionality, so this PR removes this functionality along with displaying deprecation warning and also cleaning up old template and leftovers of this command

Related Issue

Fixes #164

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

i5pranay93 and others added 11 commits May 4, 2021 15:18
@i5pranay93
cleaning up all the old template files test for build_cookbook also a…
7112f80 
…dding deprecation warning

Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@i5pranay93
adding rspec test for deprecation warning and exit
b48403c 
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@i5pranay93
running chef style
2c41bc9 
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@i5pranay93
adding ohai constrain for ruby 2.6
de66b22 
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@i5pranay93
adding ohai constarin
748b586 
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@i5pranay93
adressing comments
26f7eb4 
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@i5pranay93
cleaning up all the old template files test for build_cookbook also a…
66f4cc2 
…dding deprecation warning

Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@i5pranay93
running chef style
5f37542 
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@i5pranay93
adding ohai constrain for ruby 2.6
184f902 
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@i5pranay93
adding ohai constarin
0bd7517 
Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>
@tas50 @i5pranay93
Update lib/chef-cli/command/generate.rb
b9fd3ae 
Signed-off-by: Tim Smith <tsmith@chef.io>
@i5pranay93 i5pranay93 requested review from a team as code owners May 4, 2021 10:15
@tas50 tas50 merged commit 0b6c2b3 into master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the 'chef generate build-cookbook' command
2 participants
@i5pranay93 @tas50