Add some resources to data collector instead of empty run #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiahsnapp
suggested changes
Jun 14, 2017
data-collector.go
Outdated
| "cookbook_version": "0.1.1", | ||
| "conditional": "not_if { #code block }" | ||
| } | ||
| ` |
There was a problem hiding this comment.
The list's closing bracket ] is missing. Please add that and indent the resources.
Signed-off-by: Daniel DeLeo <dan@chef.io>
danielsdeleo
force-pushed
the
static-updated-resources
branch
from
3a34975
to
2e79cc4
Compare
|
derp, already changed that but forgot to commit it. done. |
|
Thanks @danielsdeleo for pointing in the right direction. As of 0.5.0 you can now use the https://github.com/jeremiahsnapp/chef-load#using-sample-json-data-files |
|
Cool, that's a better implementation anyway, I was just doing what was expedient for me at the time. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a hardcoded set of 10 updated resources to the data collector request. Ideally this would be a lot larger and configurable, but for now it's an improvement over just sending empty run data.
Signed-off-by: Daniel DeLeo dan@chef.io