Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added updated according to omnitruck url changes #3869

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Added updated according to omnitruck url changes #3869

merged 3 commits into from
Aug 20, 2024

Conversation

vviveksharma
Copy link
Collaborator

Description

  • As a part of PR we have updated the Omnitruck link used to install product with the latest api that we have created.

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

@vviveksharma vviveksharma requested a review from a team as a code owner August 5, 2024 05:21
@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for chef-server ready!

Name Link
🔨 Latest commit 107bc12
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/66c43e5703851b0008671afb
😎 Deploy Preview https://deploy-preview-3869--chef-server.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vviveksharma vviveksharma changed the title added updated according to onitruck url changes added updated according to omnitruck url changes Aug 5, 2024
@karunesh-tech
Copy link
Collaborator

@jashaik the changes were discussed earlier already with you by vivek sharma (@vviveksharma ), please review and approve the PR so that @IanMadd can proceed to the same.
CC: @kalroy

@karunesh-tech karunesh-tech mentioned this pull request Aug 7, 2024
Open
4 tasks
clintoncwolfe
clintoncwolfe suggested changes Aug 8, 2024
View reviewed changes
Copy link

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible high-consequence typo in hostname throughout. Dismiss review when corrected.

docs-chef-io/content/server/upgrades.md Outdated Show resolved Hide resolved
@jashaik
Copy link
Contributor

jashaik commented Aug 9, 2024 •
edited
Loading

Retried verify pipeline, If it is green then we are ready to merge.

IanMadd
IanMadd reviewed Aug 9, 2024
View reviewed changes
docs-chef-io/content/server/upgrades.md Outdated
Comment on lines 209 to 210
curl -L https://chefdownload-commerical.chef.io/install.sh?license_id=<LICENSE_ID> | sudo bash -s -- -P chef
export PATH=$PATH:/root/.chef/gem/ruby/2.6.0/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? It looks like the old example text is using chefdk, but this is changing to client. Shouldn't this be chef-workstation? Also line 212?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IanMadd
This was confirmed with the product team and then the changes were done.
@jashaik Can you please check this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IanMadd That's true. This is more suitable name. @sandhi18 Could you please replace it with chef-workstation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the discussion I have made the changes please resolve this conversation
@jashaik

jashaik
jashaik reviewed Aug 12, 2024
View reviewed changes
docs-chef-io/content/server/upgrades.md Outdated
curl -L https://chef.io/chef/install.sh | sudo bash -s -- -P chefdk
export PATH=$PATH:/root/.chefdk/gem/ruby/2.6.0/bin
curl -L https://chefdownload-commerical.chef.io/install.sh?license_id=<YOUR LICENSE ID> | sudo bash -s -- -P chef-workstation
export PATH=$PATH:/root/chef-workstation/gem/ruby/2.6.0/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export PATH=$PATH:/root/chef-workstation/gem/ruby/2.6.0/bin
export PATH=$PATH:/root/.chef-workstation/gem/ruby/2.6.0/bin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vviveksharma Did you try these steps by running?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jashaik
Our licensing team can only confirm on the install endpoint success for the given product. Hence we can ensure that the endpoint -

curl -L https://chefdownload-commerical.chef.io/install.sh?license_id= | sudo bash -s -- -P chef-workstation
this has been tested, so it will work. Overall end to end steps is something is close to product so we won't be able to test and make a callout that it work, that is the reason we are involving dev teams of those products.

@vviveksharma vviveksharma force-pushed the vivekSharma/omnitruck-updates branch 2 times, most recently from a0721e1 to 793c530 Compare August 12, 2024 06:55
@IanMadd IanMadd added the Documentation Pulls PR onto docs board so they know it exists label Aug 12, 2024
@vviveksharma vviveksharma changed the title added updated according to omnitruck url changes Added updated according to omnitruck url changes Aug 14, 2024
@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@vviveksharma @jashaik
addedd chef-workstaion as product
24846a8 
Signed-off-by: vviveksharma <visharma@progress.com>
vviveksharma and others added 2 commits August 20, 2024 12:27
@vviveksharma @jashaik
added updated according to onitruck url changes
6f9ef2d 
Signed-off-by: vviveksharma <visharma@progress.com>
@IanMadd @jashaik
Doc editing
107bc12 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@jashaik jashaik force-pushed the vivekSharma/omnitruck-updates branch from 62ccae1 to 107bc12 Compare August 20, 2024 06:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jashaik jashaik merged commit f0799a0 into main Aug 20, 2024
11 of 14 checks passed
@jashaik jashaik deleted the vivekSharma/omnitruck-updates branch August 20, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@jashaik jashaik jashaik approved these changes

@kalroy kalroy Awaiting requested review from kalroy

@sreepuramsudheer sreepuramsudheer Awaiting requested review from sreepuramsudheer

@clintoncwolfe clintoncwolfe Awaiting requested review from clintoncwolfe

@sandhi18 sandhi18 Awaiting requested review from sandhi18

@karunesh-tech karunesh-tech Awaiting requested review from karunesh-tech

Assignees
No one assigned
Labels
Documentation Pulls PR onto docs board so they know it exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vviveksharma @karunesh-tech @jashaik @clintoncwolfe @IanMadd @sandhi18