-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added updated according to omnitruck url changes #3869
Conversation
✅ Deploy Preview for chef-server ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@jashaik the changes were discussed earlier already with you by vivek sharma (@vviveksharma ), please review and approve the PR so that @IanMadd can proceed to the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible high-consequence typo in hostname throughout. Dismiss review when corrected.
Retried verify pipeline, If it is green then we are ready to merge. |
2f2590c
to
d296609
Compare
curl -L https://chefdownload-commerical.chef.io/install.sh?license_id=<LICENSE_ID> | sudo bash -s -- -P chef | ||
export PATH=$PATH:/root/.chef/gem/ruby/2.6.0/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? It looks like the old example text is using chefdk, but this is changing to client. Shouldn't this be chef-workstation
? Also line 212?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the discussion I have made the changes please resolve this conversation
@jashaik
5b6e55b
to
f4febc1
Compare
f4febc1
to
854b350
Compare
curl -L https://chef.io/chef/install.sh | sudo bash -s -- -P chefdk | ||
export PATH=$PATH:/root/.chefdk/gem/ruby/2.6.0/bin | ||
curl -L https://chefdownload-commerical.chef.io/install.sh?license_id=<YOUR LICENSE ID> | sudo bash -s -- -P chef-workstation | ||
export PATH=$PATH:/root/chef-workstation/gem/ruby/2.6.0/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export PATH=$PATH:/root/chef-workstation/gem/ruby/2.6.0/bin | |
export PATH=$PATH:/root/.chef-workstation/gem/ruby/2.6.0/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vviveksharma Did you try these steps by running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jashaik
Our licensing team can only confirm on the install endpoint success for the given product. Hence we can ensure that the endpoint -
curl -L https://chefdownload-commerical.chef.io/install.sh?license_id= | sudo bash -s -- -P chef-workstation
this has been tested, so it will work. Overall end to end steps is something is close to product so we won't be able to test and make a callout that it work, that is the reason we are involving dev teams of those products.
a0721e1
to
793c530
Compare
bbb42d8
to
2fdee94
Compare
|
Signed-off-by: vviveksharma <visharma@progress.com>
Signed-off-by: vviveksharma <visharma@progress.com>
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
62ccae1
to
107bc12
Compare
|
Description
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List