Chef Solo 12.x '--no-fork' is broken

[fujin]

It looks like the code in application.rb regarding specific recipes https://github.com/opscode/chef/blob/12.0.3/lib/chef/application.rb#L203-L205 introduces a new cli/cfg parameter which was not added to Solo, so it ends up passing a nil through from Chef::Config[:specific_recipes] inside solo.rb @ https://github.com/opscode/chef/blob/12.0.3/lib/chef/application/solo.rb#L217

Looks like introducing the cli argument from client.rb into solo.rb outta fix it, but I haven't tested that yet.

[tyler-ball]

This looks to me like https://github.com/opscode/chef/blob/12.0.3/lib/chef/application/client.rb#L255 needs to be copied into solo.rb or into the super reconfigure method in application.rb.

To get around this for now you could add specific_recipes ['recipe[my_recipe]'] to your client.rb or knife.rb. The only thing missing is the interpolation of extra command line arguments into :specific_recipes.

It looks like the banner for chef-client and chef-solo need to be updated as well. They don't indicate that you can pass recipes in as extra command line arguments.

[fujin]

hey @tyler-ball thanks for checking. I do have that Chef::Config[:specific_recipes] line already, but the solo application is bailing saying that cli_arguments is invalid. I'll take another look soon.

Was it was intended for solo to have this feature? (it looks like it was half added) which explains the lack of banner updates. I think it would be fine for both solo/client to have this feature.

[fujin]

not sure if adding it to application.rb was the right call now ❓

[tyler-ball]

@fujin Would you mind opening a PR and linking that to this bug? That will make it easier to review the code.

I don't think we want to modify application.rb. Knife is also a Chef::Application and it has a different CLI contract. The applications that look like they need this are application/apply.rb, application/client.rb and application/solo.rb

[fujin]

the PR is here: #2710 I'll move the specific recipes to apply,client,solo despite the duplication

[juliandunn]

Closing, #2710 was merged