-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chef Solo 12.x '--no-fork' is broken #2709
Comments
This looks to me like https://github.com/opscode/chef/blob/12.0.3/lib/chef/application/client.rb#L255 needs to be copied into solo.rb or into the super To get around this for now you could add It looks like the banner for chef-client and chef-solo need to be updated as well. They don't indicate that you can pass recipes in as extra command line arguments. |
hey @tyler-ball thanks for checking. I do have that Was it was intended for solo to have this feature? (it looks like it was half added) which explains the lack of banner updates. I think it would be fine for both solo/client to have this feature. |
not sure if adding it to application.rb was the right call now ❓ |
@fujin Would you mind opening a PR and linking that to this bug? That will make it easier to review the code. I don't think we want to modify application.rb. Knife is also a |
the PR is here: #2710 I'll move the specific recipes to apply,client,solo despite the duplication |
* Share specific recipes code to application parent * Update specs to passing, update specs to RSpec 3. * Specs for set_specific_recipes, solo, client.
* Share specific recipes code to application parent * Update specs to passing, update specs to RSpec 3. * Specs for set_specific_recipes, solo, client.
Closing, #2710 was merged |
It looks like the code in application.rb regarding specific recipes https://github.com/opscode/chef/blob/12.0.3/lib/chef/application.rb#L203-L205 introduces a new cli/cfg parameter which was not added to Solo, so it ends up passing a nil through from
Chef::Config[:specific_recipes]
inside solo.rb @ https://github.com/opscode/chef/blob/12.0.3/lib/chef/application/solo.rb#L217Looks like introducing the cli argument from client.rb into solo.rb outta fix it, but I haven't tested that yet.
The text was updated successfully, but these errors were encountered: