Interpolate %{path} in verify command

[margueritepd]

See #3232

[coderanger]

Can you add a comment indicating why there are two? Maybe that would give us a mild chance of remembering to remove the old one for Chef 13.

[ranjib]

@coderanger RFC says the variable name should be path. current implementation uses file . Keeping file as it is will ensure nothing breaks downstream

[stevendanna]

@ranjib I believe @coderanger was asking for a comment in the code for people who come across it later. I'm 👍 on having a code comment about why we have two.

[coderanger]

Yes, we can't remove file until Chef 13, but we should eventually revisit to clean this up.

[ranjib]

@margueritepd that helper method name should be something different, in itself its not a test. may be platform_specific_command ?
@coderanger i cant think of a way to throw deprecation warning for file usage, else it would have helped..
👍

[ranjib]

@stevendanna ah .. got it now

[coderanger]

Chef::Log.deprecate('%{file} is deprecated in favor of %{path}') if @command.include?('%{file}')

or something like that.

[margueritepd]

@coderanger comment and deprecation warning added, tests updated :)

I didn't use Chef::Log.deprecation because that throws an error apparently.

[mcquin]

@margueritepd there is a configuration option for treating deprecation warnings as errors. It's best to use Chef::Log.deprecation.

[margueritepd]

@mcquin back to using deprecation!

[mcquin]

👍