Use __dir__ instead of getting the dir of __FILE__ #10401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this is also running into this issue: https://bugs.ruby-lang.org/issues/13126 |
|
Time to update that chefstyle rule! |
This is a bit easier to read Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
mwrock
approved these changes
Sep 9, 2020
|
for some reason "the dir of |
lamont-granquist
approved these changes
Sep 9, 2020
phiggins
reviewed
Sep 9, 2020
tasks/rspec.rb
Outdated
Comment on lines
23
to
24
| CHEF_ROOT = File.join(__dir__, "..") | ||
|
|
There was a problem hiding this comment.
Suggested change
| CHEF_ROOT = File.join(__dir__, "..") |
This isn't referenced anywhere.
phiggins
approved these changes
Sep 9, 2020
Co-authored-by: pete higgins <pete@peterhiggins.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit easier to read
Signed-off-by: Tim Smith tsmith@chef.io