Fix idempotency issues with network mounts #11261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves chef#11255 This is basically a continuation of chef#11031 where I fixed it in one place but then created a regression with idempotency as noted in chef#11255. This ensures that the /etc/fstab file actually gets the output we expect with network mounts using a root device. Signed-off-by: Lance Albertson <lance@osuosl.org>
|
@tas50 @lamont-granquist I don't think the failures on related to my change but please take a look at this. I'll backport to chef-16 if you approve. |
|
@ramereth is there a reasonable way to write a unit test here? |
|
@tas50 probably, let me look into it |
tas50
reviewed
Mar 29, 2021
lib/chef/provider/mount.rb
Outdated
| @@ -176,7 +176,12 @@ def wait_until_unmounted(tries) | |||
| # Returns the new_resource device as per device_type | |||
| def device_fstab | |||
| # Removed "/" from the end of str, because it was causing idempotency issue. | |||
There was a problem hiding this comment.
Can you expand this comment a bit since we're beyond the single chomp scenario described there
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
jaymzh
approved these changes
Mar 29, 2021
|
Thanks @ramereth. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11255
This is basically a continuation of #11031 where I fixed it in one place but then created a regression with idempotency as noted in #11255. This ensures that the /etc/fstab file actually gets the output we expect with network mounts using a root device.
Signed-off-by: Lance Albertson lance@osuosl.org