Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous double mixin for the require. #11581

Merged
merged 1 commit into from
May 14, 2021

Conversation

Dylan-M
Copy link
Contributor

@Dylan-M Dylan-M commented May 14, 2021

Description

There is a bad require call in knife/lib/chef/knife/ssl_fetch.rb where a path was accidentally doubled. This fixes that by removing the extraneous extra keyword.

Related Issue

Fixes knife ssl fetch broken with bad require call in ssl_fetch.rb #11580

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Dylan Myers <dylan.myers@bluemedora.com>
@Dylan-M Dylan-M requested review from a team as code owners May 14, 2021 14:09
@tas50 tas50 merged commit 2a45e95 into chef:master May 14, 2021
@tas50
Copy link
Contributor

tas50 commented May 14, 2021

Nice catch. Thanks @Dylan-M

@Dylan-M Dylan-M deleted the double_mixin branch May 14, 2021 15:26
@Dylan-M
Copy link
Contributor Author

Dylan-M commented May 14, 2021

No problem @tas50! It frustrated me yesterday while trying to get my new laptop set up, and I was too blind to see the double path. Looked at it again this morning and had a nice "Doh!" moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants