CHEF-4791 Add more windows service states to the start/stop control flow #1166
Conversation
| Chef::Log.debug "#{@new_resource} already started - nothing to do" | ||
| else | ||
| elsif state == START_PENDING | ||
| Chef::Log.debug "#{@new_resource} already sent start signal - waiting for start" |
There was a problem hiding this comment.
Whitespaces here seems to be off.
|
Thanks for spending time on this @deployable. Other than the whitespace issues, can we add a spec that covers I'm 👍 @adamedx can you take a look over this as well? |
|
Sorry.. that's not right =/ |
Fixed deprecation warnings for `stub!` and `mock` in tests. Added tests for `START_PENDING` and `STOP_PENDING` state to `stop_service` and `start_service`
|
Not sure if you caught that update but I had to reset a commit that accidentally pulled some extra changes in from a rebase... all good now. White space fixed and some more tests added. I haven't added a failure test for a service not leaving the |
|
Sweet thanks @deployable. Marked for merge 👍 |
thommay
added
Type: Bug
Add start_pending and stop_pending to the controllalbe list (stopped,started)
Raise exceptions on hitting any other states
Add test's for exceptions on uncontrollable states.
http://msdn.microsoft.com/en-us/library/windows/desktop/ee126211(v=vs.85).aspx