Cleanup windows_printer_port and allow updating the port #11662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use converge_by here so there's no need to then use powershell_script which is slower than just running powershell_exec! Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
changed the title
tas50
force-pushed
the
windows_printer_port
branch
4 times, most recently
from
87a957f
to
4e523a2
Compare
Load the state fully / remove the exists? method Delete the power with the powershell cmdlet Add updating to the create action Deprecate the description property which never did anything Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
windows_printer_port
branch
4 times, most recently
from
b1bb8d2
to
3387056
Compare
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
windows_printer_port
branch
from
3387056
to
b9d61fa
Compare
lamont-granquist
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tim Smith tsmith@chef.io