Support attribute block/allow list in data collector #11674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
approved these changes
Jun 8, 2021
|
Tjhis should be passing everything now, but I want to take a final pass through manual verification of received payload before/after this change. |
This adds a new AttributeWhitelistConfiguration deprecation so that we don't report use of whitelist as blacklist. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
This will provide callers (such as event dispatch handlers) with a means to capture node data that has been filtered based on attribute whitelist/blacklist rules. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
This uses the newly exposed Chef::Node#data_for_save to ensure that the data we're submitting to data collector has allow/block rules applied, the same way that we do for node.save. Fixes #10895 Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the attribute block and allow list filtering has been extended to the Automate data collector. This will make captured attributes consistent across Automate and Chef Infra Server.
Fixes #10895