secrets: add support for default config from ohai data #11853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
approved these changes
Jul 26, 2021
tas50
added
the
Expeditor: Bump Version Minor
This will allow them to use node attributes for configuration, such as ohai data for determining region. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
When region is not specified and is not in AWS global configuration, we'll now default to the region in `node["ec2"]["region"]`; and we will fail if that is also not provided. This provides a sane and predictable way to play nicely with AWS SDK's default config loading behavior. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides access to the
run_contextfor secrets fetchers and specifically allows the ec2 fetcher to determine region from ohai data.The config fetch priority is:
This provides a sane and predictable way to play nicely with AWS SDK's
default config loading behavior while still supporting loading config based on node/ohai attributes
TLDR -
regionis not required to fetch an AWS secret, assuming that the ec2 ohai plugin is not disabled.Closes #11851