Allow az vault name to be included in secret name #11867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
reviewed
Jul 27, 2021
tas50
reviewed
Jul 27, 2021
marcparadise
force-pushed
the
mp/11852
branch
2 times, most recently
from
6ae9c43
to
1d0af2e
Compare
This modifies the `:azure_key_vault` fetcher so that it's possible to fetch a secret by embedding the vault name in the secret name instead of providing it in configuration. This continues down the path of making secrets accessible with less typing and sane default expectations. Example: ``` file "/home/ubuntu/test2" do content secret(name: "test-chef-infra-secrets/test-secret-1", service: :azure_key_vault) end ``` Specifying vault name via configuration is still supported, but if it is specified in the secret name as well that will take precedence. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
Thanks @marcparadise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
:azure_key_vaultfetcher so that it's possibleto fetch a secret by embedding the vault name in the secret name
instead of providing it in configuration. This continues down the path
of making secrets accessible with less typing and sane default
expectations.
Example:
Specifying vault name via configuration is still supported, but if it is
specified in the secret name as well that will take precedence.
Fixes: #11852
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com