Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom docker pipeline for multiarch builds #11871

Merged
merged 6 commits into from
Jul 28, 2021

Conversation

nkierpiec
Copy link

@nkierpiec nkierpiec commented Jul 28, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Nathaniel Kierpiec added 3 commits July 16, 2021 14:38
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
@nkierpiec nkierpiec added the Do Not Merge Do not merge label Jul 28, 2021
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
Copy link
Contributor

@jeremiahsnapp jeremiahsnapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really awesome! I just have a couple comments.

.expeditor/promote-docker-images.sh Outdated Show resolved Hide resolved
.expeditor/build-docker-images.sh Outdated Show resolved Hide resolved
Nathaniel Kierpiec added 2 commits July 28, 2021 12:34
…en promotions happen

Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
@nkierpiec nkierpiec removed the Do Not Merge Do not merge label Jul 28, 2021
@tas50 tas50 merged commit 20567cc into master Jul 28, 2021
@tas50 tas50 deleted the nkierpiec/test-arm64-docker-builds branch July 28, 2021 17:11
export DOCKER_CLI_EXPERIMENTAL=enabled

echo "--- Creating manifest for ${EXPEDITOR_TARGET_CHANNEL}"
docker manifest create "chef/chef:${EXPEDITOR_TARGET_CHANNEL}" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest that we move this to a function

function create_and_push_manifest ()  {
     echo "---  Creating..."
     docker manifest create ${1}:${2}" \
         --amend ${1}:${EXPEDITOR_VERSION}-arm64 \
         --amend ....-amd64

     echo "--- Pushing...."
     docker manifest push....
}
create_and_push_manifest "chef/chef" "${EXPEDITOR_TARGET_CHANNEL}"
 
if ....
   create_and_pus_manifest "chef/chef" "latest"
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants