-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom docker pipeline for multiarch builds #11871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
jeremiahsnapp
suggested changes
Jul 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really awesome! I just have a couple comments.
…en promotions happen Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
jeremiahsnapp
approved these changes
Jul 28, 2021
mimaslanka
reviewed
Jul 28, 2021
export DOCKER_CLI_EXPERIMENTAL=enabled | ||
|
||
echo "--- Creating manifest for ${EXPEDITOR_TARGET_CHANNEL}" | ||
docker manifest create "chef/chef:${EXPEDITOR_TARGET_CHANNEL}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest that we move this to a function
function create_and_push_manifest () {
echo "--- Creating..."
docker manifest create ${1}:${2}" \
--amend ${1}:${EXPEDITOR_VERSION}-arm64 \
--amend ....-amd64
echo "--- Pushing...."
docker manifest push....
}
create_and_push_manifest "chef/chef" "${EXPEDITOR_TARGET_CHANNEL}"
if ....
create_and_pus_manifest "chef/chef" "latest"
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist: