update dockerfile to use correct package for os/arch #11883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathaniel Kierpiec <nkierpiec@chef.io>
jeremiahsnapp
approved these changes
Jul 29, 2021
mimaslanka
reviewed
Jul 29, 2021
| @@ -2,13 +2,24 @@ | |||
| set -eu -o pipefail | |||
|
|
|||
| arch=$1 | |||
|
|
|||
| if [[ $arch == "arm64" ]]; then | |||
There was a problem hiding this comment.
Style. Fill free to skip.
I prefer not doing if/else in this case but to set a default and then override:
dockerfile_pkg_version="6"
dockerfile_arch="x86_64"
if [[ $arch == "arm64" ]]; then
dockerfile_pkg_version="7"
dockerfile_arch="aarch64"
fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Dockerfile to pull in the correct version of chef when building for arm
Types of changes
Checklist: