Use ** when passing options in subversion provider

[tomhughes]

Description

Ruby 3 as used in chef 17 requires that the options be dereferenced with ** or they will be interpreted as an extra argument.

Without this change the subversion provider is totally broken in chef 17 and unable to do anything useful.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[tas50]

Thanks @tomhughes. Any chance OSM has a nice small subversion repo we could checkout in our Test Kitchen tests?

[tomhughes]

Well https://svn.openstreetmap.org/ is still up at the moment though it's read only now - there are no immediate plans to shut it down completely.

I think the only place we actually use it in our cookbooks now is for wordpress - they have a git mirror for the core now but plugins and themes are still svn only.