Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New launchd key for associating a bundle identifier with Login Items #13288

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

chilcote
Copy link
Contributor

Description

Example of what it will look like in a plist

<key>AssociatedBundleIdentifiers</key>
<array>
    <string>bundle.id.of.app.signed.by.same.team</string>
</array>

Apple docs: https://developer.apple.com/documentation/servicemanagement/updating_helper_executables_from_earlier_versions_of_macos

Related Issue

13287

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • [x ] I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@chilcote chilcote requested review from a team as code owners October 24, 2022 18:13
@github-actions github-actions bot added the documentation How do we use this project? label Oct 24, 2022
@johnmccrae
Copy link
Contributor

@chilcote - Joseph, thanks for this. Waiting on the docs team. Would you mind adding a DCO to this too? Ian is supposed to be back today. I'll see what we can get done and get this merged before I ship the full Chef-18 release

@tpowell-progress tpowell-progress added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Nov 8, 2022
jaymzh
jaymzh previously requested changes Nov 8, 2022
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending back to author - need DCO (sign-off) before we can merge.

Signed-off-by: Joseph Chilcote <chilcote@gmail.com>
@chilcote chilcote force-pushed the associated_bundle_identifiers branch from 4371e97 to 1496fca Compare November 8, 2022 21:39
@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chilcote
Copy link
Contributor Author

chilcote commented Nov 8, 2022

did I do that right?

@chilcote chilcote requested a review from jaymzh November 17, 2022 03:42
@tpowell-progress tpowell-progress merged commit 703953c into chef:main Nov 29, 2022
@tpowell-progress tpowell-progress removed the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation How do we use this project?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants