Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sean simmons progress/bugfix/precommand #13646

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Sean simmons progress/bugfix/precommand #13646

merged 5 commits into from
Mar 22, 2023

Conversation

sean-simmons-progress
Copy link
Contributor

@sean-simmons-progress sean-simmons-progress commented Mar 22, 2023 •
edited
Loading

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@sean-simmons-progress
adding x for debug
6be9de1 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
removing filter for test
d84a800 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
updating regular expression to test habitat/build
5378697 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
removing debug
bcce3ba 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@PrajaktaPurohit
Copy link
Contributor

What is the bug this is fixing?

@sean-simmons-progress
Copy link
Contributor Author

What is the bug this is fixing?

It is fixing this not running: https://buildkite.com/chef/chef-chef-main-habitat-build/builds/2025

@sean-simmons-progress
adding docker build to this regular expression as well
0874c29 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johnmccrae johnmccrae merged commit 88d197e into main Mar 22, 2023
@johnmccrae johnmccrae deleted the sean-simmons-progress/bugfix/precommand branch March 22, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajaktaPurohit PrajaktaPurohit PrajaktaPurohit approved these changes

@johnmccrae johnmccrae johnmccrae approved these changes

@tpowell-progress tpowell-progress Awaiting requested review from tpowell-progress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sean-simmons-progress @PrajaktaPurohit @johnmccrae