Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AllowClobber powershell_package resource #14382

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mikef-nl
Copy link

Description

Cuurently powershell_package does not allow for the usage of the -AllowClobber switch

Related Issue

Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@mikef-nl mikef-nl requested review from a team as code owners May 17, 2024 08:48
@github-actions github-actions bot added the documentation How do we use this project? label May 17, 2024
@tpowell-progress
Copy link
Contributor

@mikef-nl Can we get a DCO on the commit, please?

@tpowell-progress tpowell-progress added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label May 21, 2024
…s project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as Indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Adds -AllowClobber to powershell package provider
@tpowell-progress tpowell-progress removed the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label May 28, 2024
@@ -44,6 +44,10 @@ class PowershellPackage < Chef::Resource::Package
description: "Skip validating module author.",
default: false, introduced: "14.3", desired_state: false

property :allow_clobber, [TrueClass, FalseClass],
description: "Overrides warning messages about installation conflicts about existing commands on a computer.",
default: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikef-nl Can you also add introduced: "18.5" so the property similar to the above properties?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added it as requested

Copy link
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "introduced" attribute to property.

@tpowell-progress tpowell-progress added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label May 28, 2024
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tpowell-progress
Copy link
Contributor

@mikef-nl for simplicity of DCO, can you git rebase -i origin/main and squash all the commits into one and then git commit --amend -s to sign the commit and git push -f?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation How do we use this project? Status: Waiting on Contributor A pull request that has unresolved requested actions from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants