-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds AllowClobber powershell_package resource #14382
base: main
Are you sure you want to change the base?
Conversation
@mikef-nl Can we get a DCO on the commit, please? |
…s project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as Indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Adds -AllowClobber to powershell package provider
@@ -44,6 +44,10 @@ class PowershellPackage < Chef::Resource::Package | |||
description: "Skip validating module author.", | |||
default: false, introduced: "14.3", desired_state: false | |||
|
|||
property :allow_clobber, [TrueClass, FalseClass], | |||
description: "Overrides warning messages about installation conflicts about existing commands on a computer.", | |||
default: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikef-nl Can you also add introduced: "18.5"
so the property
similar to the above properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added it as requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "introduced" attribute to property.
Quality Gate passedIssues Measures |
@mikef-nl for simplicity of DCO, can you |
Description
Cuurently powershell_package does not allow for the usage of the -AllowClobber switch
Related Issue
Issue
Types of changes
Checklist:
Gemfile.lock
has changed, I have used--conservative
to do it and included the full output in the Description above.