use Chef::JSONCompat.parse for file_contents #2433

[sawanoboly]

PR for #2433 and chef/chef-zero#99

HT: @cl-lab-k

[lamont-granquist]

yeah, chef-zero was written without "create_additions" or the "json_class" auto-inflation, all of the Chef::JSONCompat calls that it uses should have been #parse and not #from_json.

if there are any remaining calls to #from_json in chef-zero those are all bugs and need to be replaced (and #from_json should be hunted down and eradicated, its awful backcompat with insecure JSON usage).

[sawanoboly]

@lamont-granquist

Can I leave it up to you? Finding all bugs is difficult to me.

[jkeiser]

The best way to hunt it down would actually be grep -R lib from_json :)

[lamont-granquist]

just in lib/chef/chef_fs in this case -- unwinding the other uses of it is more annoying.

looks like this is the only one though.

[jkeiser]

In which case, 👍. Is there already a bug for from_json genocide?

[lamont-granquist]

no, its just well known pain from our past that hasn't been addressed yet.

[jkeiser]

Actually, we really need a test for this (something that fails without your patch, and succeeds with it). What exactly is going wrong? (To be clear, this is a positive change: from_json without any arguments is a terrible, horrible idea and I'm unclear how it got in there in the first place.)

And if you don't mind adding a CHANGELOG.md entry while you're at it, that would be great.

[sawanoboly]

I have updated spec 6c0b6d2.

case: from_json causes exception in node#json_create.

[2014-11-26T14:27:10+09:00] ERROR: #<NoMethodError: undefined method `each' for nil:NilClass>
/Users/sawanoboriyu/github/higanworks/chef/lib/chef/node.rb:452:in `json_create'
/Users/sawanoboriyu/github/higanworks/chef/lib/chef/json_compat.rb:85:in `map_to_rb_obj'
/Users/sawanoboriyu/github/higanworks/chef/lib/chef/json_compat.rb:72:in `from_json'
/Users/sawanoboriyu/github/higanworks/chef/lib/chef/chef_fs/file_system/chef_repository_file_system_entry.rb:68:in `minimize'
/Users/sawanoboriyu/github/higanworks/chef/lib/chef/chef_fs/file_system/chef_repository_file_system_entry.rb:61:in `write'

[sawanoboly]

@jkeiser @lamont-granquist

Hi, any update on this?
I hope that fix local mode behavior before release version 12.0.0 GA.

[jkeiser]

👍

[sawanoboly]

👍

[lamont-granquist]

dont we still need this it hasnt been merged?

[sawanoboly]

@lamont-granquist

Oh, this fix has been included on e809bb4 by @jkeiser (but without no specs 💢 ) , and already shipped.

I seemed that this PR doesn't have to keep state open.

[lamont-granquist]

Heh, and git is smart enough to resolve the merge conflict from the identical edit.

The specs are still useful, like to get those merged so we don't ever regress.

[lamont-granquist]

closed by #2823

[sawanoboly]

Thanks! 👍