Pass name by knife cil attribute

[sawanoboly]

Hi,

We can't pass attribute which named name since this change #2338 via knife ssh.

I would like to fix it.

[ranjib]

👍
chef_environment and other node attributes that are computed using method will have this issue as well.

/cc @chef/client-core

[sawanoboly]

@ranjib Yes 😃

I wrote a spec for this issue to cover compatibility on future.

And I'll run integration test to avoid same problem with my plugin like below. This build is scheduled at every night by my heroku scheduler 👍

https://circleci.com/gh/higanworks/knife-zero/20

[danielsdeleo]

Looks like this is basically duplicating the next elsif clause ( elsif data.respond_to?(attr.to_sym) ). Would it be better to change the elsif clause on line 184 to data.respond_to?(:[]) && data.has_key?(attr) ?

[danielsdeleo]

Otherwise we probably need to guard this with a respond_to? which would then completely duplicate the next elsif statement.

[tyler-ball]

Agreed about

elsif data.respond_to?(:[]) && data.has_key?(attr)
  data = data[attr]
elsif data.respond_to?(attr.to_sym)
  data = data.send(attr.to_sym)

[sawanoboly]

@danielsdeleo @tyler-ball

Thanks, that is better. I'll update my branch after a few hours.

[sawanoboly]

I've updated code to reflect comments ☺️

[danielsdeleo]

👍 from me. Would be nice to have a test that covers --attributes when the attribute doesn't exist and also there is no method with that name either. But I'd be okay to add that during merge.

[tyler-ball]

👍

[btm]

👍

I presume @danielsdeleo's comment means he's going to add a test and merge this?

[danielsdeleo]

Merged w/ 182f376