Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pry and pry-byebug to dev dependencies #4601

Merged
merged 1 commit into from Feb 29, 2016
Merged

adding pry and pry-byebug to dev dependencies #4601

merged 1 commit into from Feb 29, 2016

Conversation

mwrock
Copy link
Member

@mwrock mwrock commented Feb 18, 2016

No description provided.

@coderanger
Copy link
Contributor

Any particular reason? If it's for interactive debugging of failed tests it might be good to put it in the Gemfile in a group that CI won't install, just to save some cycles. Might not matter much given that travis caches gems though.

@mwrock
Copy link
Member Author

mwrock commented Feb 19, 2016

Yeah just for dev. I'll move to Gemfile.

@coderanger
Copy link
Contributor

pry is, I think, pure Ruby but byebug has some C heft to it so makes me pay slightly more attention to CI overhead :)

@mwrock
Copy link
Member Author

mwrock commented Feb 19, 2016

glad someone is paying attention :)

@mwrock
Copy link
Member Author

mwrock commented Feb 19, 2016

stripped out commented external test entries but I can put them back if they were left commented for a reason.

@coderanger
Copy link
Contributor

I think that's still under the :test group, but upon further investigation this is moot for now. Appveyor doesn't use --without development and Travis caches compiled gems so benefit on either.

:shipit:

@lamont-granquist
Copy link
Contributor

you could add pry-stack-explorer as well. we already ship all three of these in the omnibus-chef package, so we know they're portable enough.

@mwrock
Copy link
Member Author

mwrock commented Feb 26, 2016

added that @lamont-granquist had not heard of that - looks very cool.

@jkeiser
Copy link
Contributor

jkeiser commented Feb 29, 2016

👍

mwrock added a commit that referenced this pull request Feb 29, 2016
adding pry and pry-byebug to dev dependencies
@mwrock mwrock merged commit 8c26fb4 into master Feb 29, 2016
@mwrock mwrock deleted the pry branch February 29, 2016 20:47
@thommay thommay added Type: Enhancement Adds new functionality. and removed Enhancement labels Jan 25, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants