Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix portage provider to support version with character #4966

Merged
merged 1 commit into from May 31, 2016

Conversation

crigor
Copy link
Contributor

@crigor crigor commented May 24, 2016

I ran into an issue where chef 12 installs openssl 1.0.2d even if it's already installed. It doesn't support the character on the version, d.

According to man 5 ebuild

Versions are normally made up of two or three numbers separated by periods, such as 1.2 or 4.5.2. This string may be followed by a character such as 1.2a or 4.5.2z. Note that this letter is not meant to indicate alpha, beta, etc... status. For that, use the optional suffix; either _alpha, _beta, _pre (pre-release), _rc (release candidate), or _p (patch).

I added a test which failed before I added the fix. bundle exec rspec spec/unit/provider/package/portage_spec.rb shows passing tests.

This is my first PR on chef so let me know if I need to change anything.

@lamont-granquist
Copy link
Contributor

@chef/client-core needs review

@lamont-granquist
Copy link
Contributor

👍

1 similar comment
@thommay
Copy link
Contributor

thommay commented May 31, 2016

👍

@thommay thommay merged commit f5e9f42 into chef:master May 31, 2016
@smurawski
Copy link
Contributor

👍

@mwrock mwrock added the Bug label Jun 4, 2016
@thommay thommay added Type: Bug Does not work as expected. and removed Bug labels Jan 25, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants