windows_task with Gemfile.lock change #5997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 3, 2017 13:06
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
…operty Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
Signed-off-by: Bryan McLellan <btm@chef.io>
tas50
reviewed
Apr 3, 2017
| @@ -1,2 +1,3 @@ | |||
| --- | |||
| BUNDLE_FROZEN: "1" | |||
| BUNDLE_WITHOUT: "omnibus_package:test:pry:integration:docgen:maintenance:travis:aix:bsd:linux:mac_os_x:solaris:windows:development" | |||
There was a problem hiding this comment.
This shouldn't be merged here
There was a problem hiding this comment.
Yeah, I kind of figured that but rake dependencies:update keeps adding it back.
There was a problem hiding this comment.
rake dependencies:update_gemfile_lock
but you'll still pull in ohai which will break amazon linux -- working on that.
jugatsu
reviewed
Apr 4, 2017
| end | ||
|
|
||
| def load_task_xml(task_name) | ||
| xml_cmd = shell_out("chcp 65001 >nul 2>&1 && schtasks /Query /TN \"#{task_name}\" /XML") |
There was a problem hiding this comment.
#5886 (comment)
I also made PR to upstream chef-boneyard/windows#461
There was a problem hiding this comment.
There was a problem hiding this comment.
@btm , fixed the review comment. Turned out that I only had to remove stdout.force_encoding('UTF-8') from powershell_out("#{task_script}").stdout.force_encoding('UTF-8') to make it working in the later case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #5886 after resetting the Gemfile.lock and running
rake dependencies:updateandbundle install --no-deployment. /cc @NimishaS