[CHEF-3953] Mash class to_hash method leaves behind immutable objects #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The to_hash method in the Mash class does a shallow copy, which leaves behind immutable Mash's if it is a nested structure. This adds a method called to_hash_deep, which will recursively turn those immutable mash's into hashes
|
Link to the associated Jira ticket: http://tickets.opscode.com/browse/CHEF-3953 |
Adds a unit test for the to_hash_deep method
Replaces a unit test I accidentally removed when created a new one. Truly epic failure on my behalf now corrected
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The to_hash method in the Mash class does a shallow copy, which leaves behind immutable Mash's if it is a nested structure.
This adds a method called to_hash_deep, which will recursively turn those immutable mash's into hashes