Add hostname resource from chef_hostname cookbook #6795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/chef/resource/hostname.rb
Outdated
| # @return [String] | ||
| def updated_ec2_config_xml | ||
| begin | ||
| require "nokogiri" |
There was a problem hiding this comment.
so nokogiri is evil and this should really be rexml
tas50
force-pushed
the
hostname_resource
branch
3 times, most recently
from
566309c
to
f567ca4
Compare
Add in a new resource for managing hostnames Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
hostname_resource
branch
from
f567ca4
to
bb3fb72
Compare
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
hostname_resource
branch
from
bb3fb72
to
8244273
Compare
Avoid the dep on nokogiri Signed-off-by: Tim Smith <tsmith@chef.io>
lamont-granquist
approved these changes
Feb 15, 2018
| property :hostname, | ||
| String, | ||
| description: "The hostname if different than the resource's name", | ||
| name_property: true |
There was a problem hiding this comment.
what about slightly more compactly?
property :hostname, String, name_property: true,
description: "The hostname if different than the resource's name"
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in a new resource for managing hostnames
Signed-off-by: Tim Smith tsmith@chef.io