Fix windows_task idle_time validation

[algaut]

Description

Two improvements on the idle_time validation function for the windows_task resource:

• Compare frequency to :idle_time instead of comparing to an incomplete list of other frequencies.
• Keep all the validation logic in the function instead of splitting it between the function and where the function is called.

Issues Resolved

I din't create an issue since it seemed like an easy fix, but the previous PR #6714 on the matter had some of my windows_task resources fail when using the :onstart frequency.

Check List

• New functionality includes tests
• All tests pass
• RELEASE_NOTES.md, has been updated if required (not required for bugfixes, required for API changes)
• All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

[tas50]

@algaut Thanks for taking the time to make sure this works in additional scenarios. Do you think you could take a peak at the current specs and add a spec or two for the scenarios you think this fixes. We're looking at doing some large scale refactoring of this codebase and without specs to handle each scenario there's a good chance we'll introduce a regression here in the future.

-Tim

[algaut]

Hi Tim,
Would some specs like those work for you? Not sure if I'm supposed to use simple logic during spec definitions, but this should cover most cases for what I changed

[tas50]

@algaut I think those specs will certainly help us to avoid a regression here. Thanks. Any chance you can squash this down to a single commit and rebase it off master. We fixed some testing failures since you opened this up originally and that would let us get to green in appveyor testing.

[tas50]

Fixes #6824

[algaut]

Should be good to go now @tas50

[tas50]

Thanks @algaut

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.