Bump to ruby 2.5.0 #6838
Merged
Bump to ruby 2.5.0 #6838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably wanna turn on 2.5 in AV too since they have the image now |
|
appveyor looks busted for real-looking ruby 2.5 reasons? certainly the Chef::Exception error looks like another class namespacing issue. |
thommay
force-pushed
the
revert-6773-revert-6770-tm/ruby_25
branch
from
fff660a
to
3013ca6
Compare
lamont-granquist
force-pushed
the
revert-6773-revert-6770-tm/ruby_25
branch
2 times, most recently
from
a4eaa87
to
15b0d8f
Compare
|
it's a christmas miracle! appveyor is passing! omnibus builds are super-hosed tho. |
lamont-granquist
force-pushed
the
revert-6773-revert-6770-tm/ruby_25
branch
from
c68a53c
to
cea9a62
Compare
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
lamont-granquist
force-pushed
the
revert-6773-revert-6770-tm/ruby_25
branch
from
3a4b72d
to
25d072d
Compare
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
@chef/client-maintainers this is ready to go |
tas50
approved these changes
Mar 12, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6774