Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for knife bootstrap-preinstall-command #6861

Merged
merged 1 commit into from Feb 27, 2018
Merged

Add support for knife bootstrap-preinstall-command #6861

merged 1 commit into from Feb 27, 2018

Conversation

smcavallo
Copy link
Contributor

Signed-off-by: S. Cavallo smcavallo@hotmail.com

Add support for knife bootstrap-preinstall-command

Allows custom pre-install commands to be inserted into the bootstrap template.
A common use case is waiting for cloud-init to complete or any existing package manager locks to be released. It is possible to do this by customizing the install command or using custom bootstrap templates. Maintaining custom bootstrap templates can be difficult to keep up to date.
Allowing a custom pre-install bootstrap command would allow us to use the built-in templates without having to fork or customize the templates.

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]

Check List

Signed-off-by: S. Cavallo <smcavallo@hotmail.com>
@smcavallo smcavallo requested a review from a team February 15, 2018 16:25
@thommay thommay merged commit e1f1bd2 into chef:master Feb 27, 2018
@thommay
Copy link
Contributor

thommay commented Feb 27, 2018

Thanks @smcavallo for your contribution to Chef!

@lock
Copy link

lock bot commented Apr 28, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants