Add more introduced and description fields to resources #6899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
commented
Feb 23, 2018
lib/chef/resource/osx_profile.rb
Outdated
| class OsxProfile < Chef::Resource | ||
| provides :osx_profile, os: "darwin" | ||
| provides :osx_config_profile, os: "darwin" | ||
|
|
||
| identity_attr :profile_name |
There was a problem hiding this comment.
This came along for the ride, but it doesn't need to be here anymore since we set name_property on this attribute anyways
thommay
approved these changes
Feb 26, 2018
Turns out this is going to cause issues Signed-off-by: Tim Smith <tsmith@chef.io>
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still more, but this adds the fields to a good chunk of additional resources
Signed-off-by: Tim Smith tsmith@chef.io