Improve comma separated list splitting in group resource #7001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
approved these changes
Mar 19, 2018
thommay
approved these changes
Mar 19, 2018
tas50
force-pushed
the
group2
branch
2 times, most recently
from
f48f36f
to
574f183
Compare
|
Lots of unhappy specs on this one |
This is the same thing I did in sudo. It just makes the string parsing a bit more user spacing proof. accepted before: - 1,2,3 accepted now: - 1,2,3 - 1, 2, 3 - 1 ,2 ,3 - any combo of the above 3 Signed-off-by: Tim Smith <tsmith@chef.io>
|
Closing in favor of #7474 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same thing I did in sudo. It just makes the string parsing a bit more user spacing proof.
accepted before:
accepted now:
Signed-off-by: Tim Smith tsmith@chef.io
Description
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]
Check List