Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert a_to_s to shell_out_compact in DNF/yum #7313

Merged
merged 3 commits into from May 31, 2018

Conversation

lamont-granquist
Copy link
Contributor

work towards finishing deprecating the a_to_s api.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@lamont-granquist lamont-granquist requested a review from a team May 30, 2018 22:19
Copy link
Contributor

@tas50 tas50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broken yum/dnf in travis

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@tas50
Copy link
Contributor

tas50 commented May 31, 2018

Looks good with the string -> array fix

@lamont-granquist lamont-granquist merged commit 6cbe024 into master May 31, 2018
@lamont-granquist lamont-granquist deleted the lcg/remove-use-of-a_to_s branch May 31, 2018 18:07
@lock
Copy link

lock bot commented Jul 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants