Unification of shell_out APIs #7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
force-pushed
the
lcg/deprecate-shell-out-compact-timeout
branch
from
d581e4a
to
7896365
Compare
lamont-granquist
changed the title
converts all usage to just shell_out() from the numerous helper utilities that we've had previously. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
lamont-granquist
force-pushed
the
lcg/deprecate-shell-out-compact-timeout
branch
from
e2bbfa7
to
292d226
Compare
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
Probably wanna add this to the release notes |
|
it'll make more sense to do that with the deprecation PR |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shell_out_compact / shell_out_with_timeout / shell_out_compact_timeout are now all collapsed into simply shell_out
the
shell_out_compactedAPI is a private method which can be used to setup expectations on in rspec post-flat/compaction -- so meaningless changes to the shell_out won't cause churn in the specs.formal deprecation of the APIs comes next.