short circuit before the version_compare call #7705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
combined with the other PRs this will make most of the subclasses never even call version_compare now. the subclasses that need allow_downgrade as a feature should implement both the property and implement version_compare now. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
it is possible now that version_compare in the superclass won't ever be called and we could raise an error that it must be implemented now... IDK I feel that aggressive tonight though. |
tas50
approved these changes
Sep 28, 2018
btm
approved these changes
Sep 28, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combined with the other PRs this will make most of the
subclasses never even call version_compare now.
the subclasses that need allow_downgrade as a feature
should implement both the property and implement
version_compare now.