Add chef_vault_secret resource from chef-vault cookbook #9364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
force-pushed
the
vault_resource
branch
from
2465602
to
7742973
Compare
| action :delete do | ||
| description "Deletes the item and the item's keys ('id'_keys)." | ||
|
|
||
| converge_by("remove #{new_resource.id} and #{new_resource.id}_keys from #{new_resource.data_bag}") do |
There was a problem hiding this comment.
delete doesn't look properly idempotent here
lamont-granquist
approved these changes
Feb 13, 2020
|
i assume that bug there is years old at this point, so wouldn't consider it a blocker. |
Move this common resource into Chef itself to avoid the need to include this cookbook. Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Pulled from the cookbook. I also sprinkled some chef-utils usage on the existing test. Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
vault_resource
branch
from
7742973
to
1916341
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move this common resource into Chef itself to avoid the need to include this cookbook.
Signed-off-by: Tim Smith tsmith@chef.io