Remove the "Core" DSL for Chef-16 #9411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us avoid using declare_resource in old style core resources. As everything gets converted over to custom resources this is going away anyway. We haven't seen any issues from using the recipe DSL in custom resources in core. Clearly this is potentially breaking since any references to Chef::DSL::Core need to be changed to Chef::DSL::Recipe (although I'm not sure who would have done that other than maybe us somewhere, I had a note in there that nobody should probably touch the Core DSL). This greatly simplifies the major DSLs down to two: Recipe DSL - things that only make sense in a context where there is a resource_collection Universal DSL - things that apply everywhere Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
It is necessary due to the way the crazy lazy DSL module injection works Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
lamont-granquist
added
the
Type: Breaking Change
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us avoid using declare_resource in old style core resources.
As everything gets converted over to custom resources this is going away
anyway.
We haven't seen any issues from using the recipe DSL in custom resources
in core.
Clearly this is potentially breaking since any references to
Chef::DSL::Core need to be changed to Chef::DSL::Recipe (although I'm
not sure who would have done that other than maybe us somewhere, I had
a note in there that nobody should probably touch the Core DSL).
This greatly simplifies the major DSLs down to two:
Recipe DSL - things that only make sense in a context where there is a resource_collection
Universal DSL - things that apply everywhere
Signed-off-by: Lamont Granquist lamont@scriptkiddie.org