New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create windows_audit_policy resource #9980
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
2 tasks
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
… client run. Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
phiggins
reviewed
Jun 11, 2020
phiggins
reviewed
Jun 11, 2020
phiggins
reviewed
Jun 11, 2020
phiggins
reviewed
Jun 11, 2020
phiggins
reviewed
Jun 11, 2020
phiggins
reviewed
Jun 11, 2020
phiggins
reviewed
Jun 11, 2020
phiggins
reviewed
Jun 11, 2020
phiggins
reviewed
Jun 11, 2020
phiggins
reviewed
Jun 11, 2020
@phiggins I appreciate all the comments. I'm slammed at the moment but will try to push some updates this weekend to incorporate your suggestions. |
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
… as I can't change the name of the windows command. Signed-off-by: Davin Taddeo <davin@chef.io>
…work, I guess I'll ask for help or something ;) Signed-off-by: Davin Taddeo <davin@chef.io>
tas50
reviewed
Jun 15, 2020
tas50
reviewed
Jun 15, 2020
tas50
reviewed
Jun 15, 2020
tas50
reviewed
Jun 15, 2020
tas50
reviewed
Jun 15, 2020
tas50
reviewed
Jun 15, 2020
use provides instead of resource_name Co-authored-by: Tim Smith <tsmith@chef.io>
tas50
reviewed
Jun 15, 2020
…_AUDIT_SUBCATEGORIES constant Signed-off-by: Davin Taddeo <davin@chef.io>
… guidance with @tas50 Signed-off-by: Davin Taddeo <davin@chef.io>
tas50
reviewed
Jun 15, 2020
tas50
reviewed
Jun 15, 2020
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
Signed-off-by: Davin Taddeo <davin@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new native resource for managing Windows Advanced Audit Policy configurations. A user can specify a subcategory of the advanced audit policy to edit either as a string or an array and can set the auditing to Success and/or Failure. It also takes user arguments to apply policies to specific users. There are options for the four Advanced Audit Policy options managed via
auditpol
as well. It is idempotent in my testing as well.Some usage examples are below:
Set Logon and Logoff policy to "Success and Failure":
Set Credential Validation policy to "Success":
Enable CrashOnAuditFail option:
Related Issue
#8299
Types of changes
Checklist: