Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_private_key_with_path doesn't work well with all possible key names #62

Closed
hfinucane opened this issue Aug 18, 2015 · 5 comments · Fixed by #87
Closed

get_private_key_with_path doesn't work well with all possible key names #62

hfinucane opened this issue Aug 18, 2015 · 5 comments · Fixed by #87
Labels
Type: Bug Does not work as expected.

Comments

@hfinucane
Copy link
Contributor

If you have a private key with period characters in the name, you get down around here:

if ext == '' || ext == '.pem'
and then get confused about what you're looking for.

Probably an elsif File.exists? key block down at the end would fix it.

@mikesimons
Copy link

Just hit this w/ chef provisioning unable to find private key because it was called id_rsa.auto

@hfinucane
Copy link
Contributor Author

I signed an Opscode CLA maybe ~2 years ago. If I fixed this could I get the patch merged or do I need to go through all the motions again?

@tyler-ball
Copy link
Contributor

@hfinucane if you put out a fix PR we can get it merged!

@hfinucane
Copy link
Contributor Author

@tyler-ball please?

tyler-ball added a commit that referenced this issue Nov 18, 2015
Support arbitrarily named private keys
@hfinucane
Copy link
Contributor Author

<3

@thommay thommay added Type: Bug Does not work as expected. and removed Bug labels Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants