Added chef_service_interval option and moved encrypted_data_bag_secret option from public_config to private_config for chef_extension. #408
Conversation
…t option from public_config to private_config for chef_extension. Signed-off-by: aliasgar16 <aliasgar.batterywala@msystechnologies.com>
…RM template and added the corresponding RSpecs. Signed-off-by: aliasgar16 <aliasgar.batterywala@msystechnologies.com>
Aliasgar16
force-pushed
the
ali/integrate_chef_extension_changes
branch
from
8fefa29
to
d072bfc
Compare
|
Done. |
| :long => "--chef-service-interval INTERVAL", | ||
| :description => "Optional. It specifies the frequency (in minutes) at which the chef-service runs. | ||
| Pass 0 if you don't want the chef-service to be installed on the target machine." | ||
|
|
There was a problem hiding this comment.
$ git grep BootstrapOptions
lib/chef/knife/azure_server_create.rb: include Knife::Bootstrap::BootstrapOptions
lib/chef/knife/azurerm_server_create.rb: include Knife::Bootstrap::CommonBootstrapOptions
lib/chef/knife/bootstrap/bootstrap_options.rb: module BootstrapOptions
lib/chef/knife/bootstrap/common_bootstrap_options.rb: module CommonBootstrapOptions
lib/chef/knife/bootstrap_azure.rb: include Knife::Bootstrap::CommonBootstrapOptions
lib/chef/knife/bootstrap_azurerm.rb: include Knife::Bootstrap::CommonBootstrapOptions
It seems like BootstrapOptions vs CommonBootstrapOptions has gotten out of hand. Although I realize that these options are slightly different as cloud-api appears to optional for ASM but not ARM. So maybe nothing to do here, but this "smells."
Can you at least add comments to the top of BootstrapOptions and CommonBootstrapOptions to describe how they're supposed to be different?
| extension = "" | ||
| template["resources"].each do |resource| | ||
| extension = resource if resource["type"] == "Microsoft.Compute/virtualMachines/extensions" | ||
| end |
There was a problem hiding this comment.
Do we need to set extension to an empty string here? If it remains nil, wouldn't the expect statements fail either way?
| extension = "" | ||
| template["resources"].each do |resource| | ||
| extension = resource if resource["type"] == "Microsoft.Compute/virtualMachines/extensions" | ||
| end |
There was a problem hiding this comment.
Same question about the need to set extension to an empty string.
Signed-off-by: aliasgar16 <aliasgar.batterywala@msystechnologies.com>
|
@btm I have fixed the review comments. Please check and let me know your feedback. |
In-progress.
Signed-off-by: aliasgar16 aliasgar.batterywala@msystechnologies.com