Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix to make dir.chdir threadsafe #29

Merged
merged 1 commit into from
Aug 3, 2018
Merged

bugfix to make dir.chdir threadsafe #29

merged 1 commit into from
Aug 3, 2018

Conversation

stevenoneill
Copy link
Contributor

@stevenoneill stevenoneill commented Aug 2, 2018 •
edited
Loading

Description

Makes Dir.chdir threadsafe.

Issues Resolved

Resolves #28

Considered:

Check List

@stevenoneill stevenoneill requested a review from a team August 2, 2018 14:35
@stevenoneill stevenoneill force-pushed the steveo/fix-chdir-threadsafe branch 2 times, most recently from fb00865 to d68964b Compare August 2, 2018 15:43
cheeseplus
cheeseplus reviewed Aug 2, 2018
View reviewed changes
CHANGELOG.md Outdated

#### Merged Pull Requests
- Add github issue template & standardize expeditor config [#26](https://github.com/chef/mixlib-archive/pull/26) ([tas50](https://github.com/tas50))
- Update codeowners and add PR template [#27](https://github.com/chef/mixlib-archive/pull/27) ([tas50](https://github.com/tas50))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't update the changelog, that's handled automatically by Expeditor and it's not good practice to increment the version in a PR (that's for the maintainers to do)

cheeseplus
cheeseplus reviewed Aug 2, 2018
View reviewed changes
VERSION Outdated
0.4.12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boo-boo on my part....will get it right

@coderanger
Copy link
Contributor

While this might be a decent stopgap, the correct solution is that mixlib-archive shouldn't be using chdir at all.

@stevenoneill stevenoneill deleted the steveo/fix-chdir-threadsafe branch August 2, 2018 16:57
@stevenoneill stevenoneill restored the steveo/fix-chdir-threadsafe branch August 2, 2018 16:58
@stevenoneill stevenoneill reopened this Aug 2, 2018
@stevenoneill
Copy link
Contributor Author

stevenoneill commented Aug 2, 2018 •
edited
Loading

Hmmm....did I mess something up here? (first ever PR)

Update -- got it working

@stevenoneill
workaround to make chdir threadsafe until an alternative is found
7f91cb0 
Signed-off-by: Steven ONeill <oneill.steven@gmail.com>
tyler-ball
tyler-ball approved these changes Aug 3, 2018
View reviewed changes
Copy link

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any way to extract an entry to a new location looking at ffi-libarchive so this seems like a good solution

@tas50 tas50 merged commit c59e5ab into chef:master Aug 3, 2018
@tas50
Copy link
Contributor

tas50 commented Aug 3, 2018

Thanks @stevenoneill we'll get this pushed up asap

@stevenoneill
Copy link
Contributor Author

Awesome....thank you all! Really appreciate for the quick attention to this!

@bdwyertech bdwyertech mentioned this pull request Aug 22, 2018
Closed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 23, 2018
archivers/ruby-mixlib-archive: update to 0.4.16
2317e6a 
## [v0.4.16](https://github.com/chef/mixlib-archive/tree/v0.4.16) (2018-08-28)

#### Merged Pull Requests
- Fix read_tar_magic to properly return an array when a file has less than 264 characters [#30](chef/mixlib-archive#30) ([bdwyertech](https://github.com/bdwyertech))
<!-- latest_release -->

<!-- release_rollup since=0.4.13 -->
### Changes not yet released to rubygems.org

#### Merged Pull Requests
- Fix read_tar_magic to properly return an array when a file has less than 264 characters [#30](chef/mixlib-archive#30) ([bdwyertech](https://github.com/bdwyertech)) <!-- 0.4.16 -->
- Fix mixlib-archive on Windows, add Appveyor [#31](chef/mixlib-archive#31) ([stuartpreston](https://github.com/stuartpreston)) <!-- 0.4.15 -->
- Ensure that paths like foo..bar.baz aren&#39;t ignored [#9](chef/mixlib-archive#9) ([thommay](https://github.com/thommay)) <!-- 0.4.14 -->
<!-- release_rollup -->

<!-- latest_stable_release -->
## [v0.4.13](https://github.com/chef/mixlib-archive/tree/v0.4.13) (2018-08-03)

#### Merged Pull Requests
- add codeowners [#24](chef/mixlib-archive#24) ([thommay](https://github.com/thommay))
- Move deps to the Gemfile and expand Rake tasks [#25](chef/mixlib-archive#25) ([tas50](https://github.com/tas50))
- Add github issue template &amp; standardize expeditor config [#26](chef/mixlib-archive#26) ([tas50](https://github.com/tas50))
- Update codeowners and add PR template [#27](chef/mixlib-archive#27) ([tas50](https://github.com/tas50))
- bugfix to make dir.chdir threadsafe [#29](chef/mixlib-archive#29) ([stevenoneill](https://github.com/stevenoneill))
<!-- latest_stable_release -->

## [v0.4.8](https://github.com/chef/mixlib-archive/tree/v0.4.8) (2018-06-21)

#### Merged Pull Requests
- Use the correct entry size for content with multi-byte characters. [#23](chef/mixlib-archive#23) ([coderanger](https://github.com/coderanger))
<!-- latest_release -->

<!-- release_rollup since=0.4.7 -->
### Changes not yet released to rubygems.org

#### Merged Pull Requests
- Use the correct entry size for content with multi-byte characters. [#23](chef/mixlib-archive#23) ([coderanger](https://github.com/coderanger)) <!-- 0.4.8 -->
<!-- release_rollup -->

<!-- latest_stable_release -->
## [v0.4.7](https://github.com/chef/mixlib-archive/tree/v0.4.7) (2018-06-07)

#### Merged Pull Requests
- fixup strange edge case around tar magic reading [#22](chef/mixlib-archive#22) ([spion06](https://github.com/spion06))
<!-- latest_stable_release -->

## [v0.4.6](https://github.com/chef/mixlib-archive/tree/v0.4.6) (2018-05-08)

#### Merged Pull Requests
- update tar magic to identify oldgnu style tar headers [#21](chef/mixlib-archive#21) ([spion06](https://github.com/spion06))

## [v0.4.5](https://github.com/chef/mixlib-archive/tree/v0.4.5) (2018-05-04)

#### Merged Pull Requests
- Fix up creating archives [#18](chef/mixlib-archive#18) ([thommay](https://github.com/thommay))
- Fix up writing tar archives with the rubygems tar [#19](chef/mixlib-archive#19) ([thommay](https://github.com/thommay))

## [v0.4.2](https://github.com/chef/mixlib-archive/tree/v0.4.2) (2018-04-25)

#### Merged Pull Requests
- use libarchive by preference [#17](chef/mixlib-archive#17) ([thommay](https://github.com/thommay))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheeseplus cheeseplus cheeseplus approved these changes

@tyler-ball tyler-ball tyler-ball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stevenoneill @coderanger @tas50 @cheeseplus @tyler-ball