Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that paths like foo..bar.baz aren't ignored #9

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

thommay
Copy link
Contributor

@thommay thommay commented Feb 2, 2017

Signed-off-by: Thom May thom@may.lt

Signed-off-by: Thom May <thom@may.lt>
Copy link

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although I don't know enough about this on windows)

@tas50 tas50 requested a review from stuartpreston July 25, 2018 19:10
@tas50
Copy link
Contributor

tas50 commented Jul 25, 2018

Ping @stuartpreston for some windows insight

@stuartpreston
Copy link

I haven't tried it but I think the specs would fail on Windows because they expect a forward slash. We need either platform-specific tests or an understanding of the path separator in the tests.

@lamont-granquist lamont-granquist merged commit 746470b into master Aug 3, 2018
@lamont-granquist lamont-granquist deleted the tm/silly_paths branch August 3, 2018 21:08
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 23, 2018
## [v0.4.16](https://github.com/chef/mixlib-archive/tree/v0.4.16) (2018-08-28)

#### Merged Pull Requests
- Fix read_tar_magic to properly return an array when a file has less than 264 characters [#30](chef/mixlib-archive#30) ([bdwyertech](https://github.com/bdwyertech))
<!-- latest_release -->

<!-- release_rollup since=0.4.13 -->
### Changes not yet released to rubygems.org

#### Merged Pull Requests
- Fix read_tar_magic to properly return an array when a file has less than 264 characters [#30](chef/mixlib-archive#30) ([bdwyertech](https://github.com/bdwyertech)) <!-- 0.4.16 -->
- Fix mixlib-archive on Windows, add Appveyor [#31](chef/mixlib-archive#31) ([stuartpreston](https://github.com/stuartpreston)) <!-- 0.4.15 -->
- Ensure that paths like foo..bar.baz aren&#39;t ignored [#9](chef/mixlib-archive#9) ([thommay](https://github.com/thommay)) <!-- 0.4.14 -->
<!-- release_rollup -->

<!-- latest_stable_release -->
## [v0.4.13](https://github.com/chef/mixlib-archive/tree/v0.4.13) (2018-08-03)

#### Merged Pull Requests
- add codeowners [#24](chef/mixlib-archive#24) ([thommay](https://github.com/thommay))
- Move deps to the Gemfile and expand Rake tasks [#25](chef/mixlib-archive#25) ([tas50](https://github.com/tas50))
- Add github issue template &amp; standardize expeditor config [#26](chef/mixlib-archive#26) ([tas50](https://github.com/tas50))
- Update codeowners and add PR template [#27](chef/mixlib-archive#27) ([tas50](https://github.com/tas50))
- bugfix to make dir.chdir threadsafe [#29](chef/mixlib-archive#29) ([stevenoneill](https://github.com/stevenoneill))
<!-- latest_stable_release -->

## [v0.4.8](https://github.com/chef/mixlib-archive/tree/v0.4.8) (2018-06-21)

#### Merged Pull Requests
- Use the correct entry size for content with multi-byte characters. [#23](chef/mixlib-archive#23) ([coderanger](https://github.com/coderanger))
<!-- latest_release -->

<!-- release_rollup since=0.4.7 -->
### Changes not yet released to rubygems.org

#### Merged Pull Requests
- Use the correct entry size for content with multi-byte characters. [#23](chef/mixlib-archive#23) ([coderanger](https://github.com/coderanger)) <!-- 0.4.8 -->
<!-- release_rollup -->

<!-- latest_stable_release -->
## [v0.4.7](https://github.com/chef/mixlib-archive/tree/v0.4.7) (2018-06-07)

#### Merged Pull Requests
- fixup strange edge case around tar magic reading [#22](chef/mixlib-archive#22) ([spion06](https://github.com/spion06))
<!-- latest_stable_release -->

## [v0.4.6](https://github.com/chef/mixlib-archive/tree/v0.4.6) (2018-05-08)

#### Merged Pull Requests
- update tar magic to identify oldgnu style tar headers [#21](chef/mixlib-archive#21) ([spion06](https://github.com/spion06))

## [v0.4.5](https://github.com/chef/mixlib-archive/tree/v0.4.5) (2018-05-04)

#### Merged Pull Requests
- Fix up creating archives [#18](chef/mixlib-archive#18) ([thommay](https://github.com/thommay))
- Fix up writing tar archives with the rubygems tar [#19](chef/mixlib-archive#19) ([thommay](https://github.com/thommay))

## [v0.4.2](https://github.com/chef/mixlib-archive/tree/v0.4.2) (2018-04-25)

#### Merged Pull Requests
- use libarchive by preference [#17](chef/mixlib-archive#17) ([thommay](https://github.com/thommay))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants