Return nil when looking up non-existing products #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `PRODUCT_MATRIX.lookup` for a product that does not exist, we'd try to call the `version` method on nil, resulting in an "undefined method" error. Now we return nil to the caller early before trying to manipulate it. Signed-off-by: Adam Leff <adam@leff.co>
scotthain
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
PRODUCT_MATRIX.lookupfor a product that does not exist,we'd try to call the
versionmethod on nil, resulting in an "undefinedmethod" error. Now we return nil to the caller early before trying to
manipulate it.
Signed-off-by: Adam Leff adam@leff.co