Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return nil when looking up non-existing products #241

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Return nil when looking up non-existing products #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/mixlib/install/product.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ def products
#
# @return [Product]
def lookup(key, version = :latest)
# return nil unless the product exists
return nil unless @product_map.key?(key)

product = @product_map[key]
# We set the lookup version for the product to a very high number in
# order to mimic :latest so that one does not need to handle this
Expand Down
4 changes: 4 additions & 0 deletions spec/unit/mixlib/install/product_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,10 @@
end
end

it "returns nil when looking up a non-existent product" do
expect(PRODUCT_MATRIX.lookup("no-such-project")).to be_nil
end

it "returns nil for unset parameters" do
expect(PRODUCT_MATRIX.lookup("chef").ctl_command).to be_nil
end
Expand Down