Merge pull request #386 from juliandunn/getlogin-lies

getlogin() often lies, especially when run under "su"
chef · Aug 15, 2014 · 28dcc46 · 28dcc46
2 parents a8bd2e0 + fec9467
commit 28dcc46
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/ohai/plugins/passwd.rb b/lib/ohai/plugins/passwd.rb
@@ -32,7 +32,7 @@ def fix_encoding(str)
     end
 
     unless current_user
-      current_user fix_encoding(Etc.getlogin)
+      current_user fix_encoding(Etc.getpwuid(Process.euid).name)
     end
   end
 end
diff --git a/spec/unit/plugins/passwd_spec.rb b/spec/unit/plugins/passwd_spec.rb
@@ -24,7 +24,8 @@
   end
 
   it "should set the current user" do
-    Etc.should_receive(:getlogin).and_return('chef')
+    Process.should_receive(:euid).and_return('31337')
+    Etc.should_receive(:getpwuid).and_return(PasswdEntry.new('chef', 31337, 31337, '/home/chef', '/bin/ksh', 'Julia Child'))
     @plugin.run
     @plugin[:current_user].should == 'chef'
   end