getlogin() often lies, especially when run under "su" #386
Conversation
…urns the calling user, so node['current_user'] is set incorrectly in this case. According to the Ruby documentation, it's safer to use getpwuid().
|
Would this be a potential backwards compat issue? |
|
I guess it's technically a breaking change, though the old behavior is a bug. We should call it out in release notes or something. |
|
So, technically its not really a lie, its just that getlogin uses the 'real' uid while you've changed it to report the 'effective' uid -- but 'effective' uid is really what you're trying to get at... When running 'su ohai' you want it to be 'root' and not the caller of su. Seems to fix behavior that nobody wants, so I wouldn't really consider it 'breaking'. 👍 |
getlogin() often lies, especially when run under "su"
|
Sorry for joining this conversation so late, I've only just noticed this change with ohai 8.0.1. Unfortunately Pivotal Sprout's cookbooks rely pretty heavily on the old behavior and in fact have relied on it for quite a few years now. Did folks run into real world recipes/situations where the new behavior was needed? |
Run under "su", Ohai incorrectly returns the calling user as
node['current_user']becausegetlogin()lies to us.According to the Ruby documentation, it's safer to use getpwuid().