virtualization does not detect centos 7.1 kvm guests running on a centos 7.1 host

[conathan]

Looking at https://github.com/chef/ohai/blob/master/lib/ohai/plugins/linux/virtualization.rb, It uses the following to detect whenever it is running as a kvm guest:

  if File.read("/proc/cpuinfo") =~ /QEMU Virtual CPU|Common KVM processor|Common 32-bit KVM processor/
    virtualization[:system] = "kvm"
    virtualization[:role] = "guest"
    virtualization[:systems][:kvm] = "guest"

  when /Manufacturer: QEMU/
    virtualization[:system] = "kvm"
    virtualization[:role] = "guest"
    virtualization[:systems][:kvm] = "guest"

In this case, I have the following for cpuinfo:
vendor_id : GenuineIntel
model name : Intel(R) Core(TM)2 Duo CPU T7700 @ 2.40GHz

and for dmidecode

Handle 0x0100, DMI type 1, 27 bytes
System Information
Manufacturer: Red Hat
Product Name: KVM
Version: RHEL 7.0.0 PC (i440FX + PIIX, 1996)
Serial Number: Not Specified
UUID: 6E56CFE2-2088-4A46-906A-FC49EDC4072C
Wake-up Type: Power Switch
SKU Number: Not Specified
Family: Red Hat Enterprise Linux

I worked around that by using the following:

  require 'ohai/util/file_helper'

  include Ohai::Util::FileHelper

  Ohai.plugin(:VirtualizationKvm) do
    provides "virtualization"
    collect_data(:linux) do
      # http://www.dmo.ca/blog/detecting-virtualization-on-linux
      if File.exists?("/usr/sbin/dmidecode")
        so = shell_out("dmidecode")
        case so.stdout
        when /Product Name: KVM/
          virtualization[:system] = "kvm"
          virtualization[:role] = "guest"
          virtualization[:systems][:kvm] = "guest"
        else
          nil
        end
      end
    end
  end

[mcquin]

Thanks for the infos.

It looks like we'll just have to change this line to

when /Manufacturer: QEMU|Product Name: KVM/

[mcquin]

#594

[conathan]

Thank you, new virtualization.rb seems to work (used ohai-8.5.0 and just grabbed the latest plugins/linux/virtualization.rb from the above pull).

[mcquin]

Great! Thanks for the check @conathan ! :)