Move ohai to structured logging #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2018 16:53
This allows us to bubble up a single logging object with metadata throughout ohai, rather than the current janky way. We also move some debug output to trace. Signed-off-by: Thom May <thom@chef.io>
Signed-off-by: Thom May <thom@chef.io>
thommay
changed the title
tas50
reviewed
Mar 16, 2018
| @@ -31,7 +31,7 @@ | |||
| # Notification: kqueue | |||
| # Architecture: amd64 | |||
| # Disabled: none | |||
| # Misc: softdebug | |||
| # Misc: softtrace | |||
lamont-granquist
approved these changes
Mar 16, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
it moves away from the old model of using a log module throughout, to injecting the logger in to the various classes. This means that each class can attach metadata to the logger, allowing - in future - us to add tooling to drill into specific plugins or similar.
It converts (the second commit) everything to be at log level trace rather than debug. In general, a cookbook author does not give two hoots about which ohai plugins are loaded or in we failed to load a hint on azure, and we should respect their attention.