Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Expeditor to clean branches / bump minors #1223

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jul 9, 2018

Cleanup branches post PR merge
Add ability to bump minor via label
Remove the branch config for Ohai 8 (chef 12)

Signed-off-by: Tim Smith tsmith@chef.io

@tas50 tas50 requested a review from a team July 9, 2018 18:58
Cleanup branches post PR merge
Add ability to bump minor via label
Remove the branch config for Ohai 8 (chef 12)

Signed-off-by: Tim Smith <tsmith@chef.io>
# The tag format to use (e.g. v1.0.0)
version_tag_format: "v{{version}}"
# The Github Team primarily responsible for handling incoming Pull Requests.
maintainer_group: chef/client-maintainers
# allow bumping the minor release via label
minor_bump_labels:
- "Expeditor: Bump Minor Version"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Version: Bump Minor so it matches idioms across other Chef projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we don't align this all under Expeditor labels? Version: Bump Minor seems to break the mold.

@tas50
Copy link
Contributor Author

tas50 commented Jul 23, 2018

Merging based on PR review conversation

@tas50 tas50 deleted the expeditor_updates branch July 23, 2018 17:15
@tas50 tas50 added Triage: Needs Information Indicates an issue needs more information in order to work on it. and removed Status: Pending Contributor Response labels Jan 2, 2019
@lock
Copy link

lock bot commented Jan 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Triage: Needs Information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants