Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define CONVERSION_STATUS only if it wasn't defined earlier #1375

Merged

Conversation

balasankarc
Copy link

Note: This PR targets 14-stable branch, as it is looking at fixing a problem in Chef-14

Closes: #1276

When ohai is reloaded, Ruby warns about CONVERSION_STATUS constant being already defined. This PR fixes those warnings.

Types of changes

  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@balasankarc balasankarc force-pushed the fix-conversion-status-const-chef-14 branch from 09f6b6f to 638495a Compare June 12, 2019 09:45
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
@balasankarc balasankarc force-pushed the fix-conversion-status-const-chef-14 branch from 638495a to e7d58f1 Compare June 12, 2019 13:04
@tas50 tas50 changed the title [Chef-14] Define CONVERSION_STATUS only if it wasn't defined earlier Define CONVERSION_STATUS only if it wasn't defined earlier Jun 12, 2019
@tas50 tas50 merged commit f1facfb into chef:14-stable Jun 12, 2019
@tas50
Copy link
Contributor

tas50 commented Jun 12, 2019

Thanks @balasankarc

@lock
Copy link

lock bot commented Aug 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
@balasankarc balasankarc deleted the fix-conversion-status-const-chef-14 branch August 16, 2019 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants