Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ohai/plugins/packages.rb - order change - present in both ohai 16 and 17 - impact chef 16/17 #1669

Merged
merged 1 commit into from
Oct 5, 2021
Merged

ohai/plugins/packages.rb - order change - present in both ohai 16 and 17 - impact chef 16/17 #1669

merged 1 commit into from
Oct 5, 2021

Conversation

knightorc
Copy link
Contributor

Change order of collect_programs_from_registry_key
move collection of Wos6432Node before HKEY_CURRENT_USER

Description

When located last, ohai packages does not report Wow6432 software

Related Issue

Found when updating from Chef 15 to Chef 16

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • [x ] I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Wade Peacock knightorc@xqqme.com

@knightorc
ohai/plugins/packages.rb - order change - impact chef16/17
6ca8519 
Change order of collect_programs_from_registry_key
move collection of Wos6432Node before HKEY_CURRENT_USER

When located last, ohai packages does not report Wow6432 software

Found when updating from Chef 15 to Chef 16

Signed-off-by: Wade Peacock <knightorc@xqqme.com>
@knightorc knightorc requested review from a team as code owners May 21, 2021 02:28
@knightorc knightorc mentioned this pull request Jun 9, 2021
Closed
@tas50 tas50 added the Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. label Jun 9, 2021
@tas50
Copy link
Contributor

tas50 commented Jun 9, 2021

@jaymzh I know you're out right now, but I'd love for you to chime in on this one before we merge it since you wrote this stuff originally.

@knightorc
Copy link
Contributor Author

@jaymzh Sorry to pester. could you present your thoughts on this purposed change to ohai Windows installed program data collection I've submitted as I see the @tas50 has deferred to you.

@knightorc
Copy link
Contributor Author

@tas50 this is still twisting in the wind. Thoughts?

@tas50 tas50 merged commit 144715b into chef:main Oct 5, 2021
@tas50
Copy link
Contributor

tas50 commented Oct 5, 2021

@knightorc Any chance you can cut this against the 16-stable branch as well?

@knightorc knightorc mentioned this pull request Oct 7, 2021
Merged
@knightorc knightorc deleted the fix_ohai_windows_packages_wow6432node branch October 7, 2021 20:09
@knightorc
Copy link
Contributor Author

OHAI-16 PR: #1697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh approved these changes

@johnmccrae johnmccrae johnmccrae approved these changes

Assignees
No one assigned
Labels
Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knightorc @tas50 @jaymzh @johnmccrae